feat: 头像裁剪组件 #2570
Merged
feat: 头像裁剪组件 #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v4 #2570 +/- ##
==========================================
- Coverage 84.99% 84.92% -0.08%
==========================================
Files 151 152 +1
Lines 20720 21172 +452
Branches 2323 2377 +54
==========================================
+ Hits 17611 17980 +369
- Misses 3104 3187 +83
Partials 5 5
☔ View full report in Codecov by Sentry. |
eiinu
reviewed
Sep 19, 2023
| | btnsPosition | 裁剪区域工具栏位置,可选值为：`top` `bottom` | string | bottom | | ||
| | editText | 中间的文字内容 | string | 编辑 | | ||
| | cancelText | 取消按钮的文字 | string | 取消 | | ||
| | cancelConfirm | 确认按钮的文字 | string | 确认 | |
eiinu
reviewed
Sep 19, 2023
| @@ -0,0 +1 @@ | |||
| export type BtnsPosition = 'top' | 'bottom'; | |||
There was a problem hiding this comment.
类型名称需要调整为组件名开头，比如 AvatarCropperxxx
eiinu
reviewed
Sep 19, 2023
| | ------------- | ------------------------------------------- | ------ | ------ | | ||
| | maxZoom | 最大缩放倍数 | number | 3 | | ||
| | space | 裁剪区域两边预留的间隙 | number | 10 | | ||
| | btnsPosition | 裁剪区域工具栏位置,可选值为：`top` `bottom` | string | bottom | |
There was a problem hiding this comment.
建议将 btns 整体调整为更语义化的 toolbar：
1、prop btnsPosition -> toolbar-position
2、slot bottom -> toolbar
3、类型名称 BtnsPosition -> AvatarCropperToolbarPosition
4、与之相关的 class 名称等等
eiinu
reviewed
Sep 19, 2023
| @@ -0,0 +1,451 @@ | |||
| <template> | |||
| <view class="nut-avatar-cropper" :data-edit-text="editText"> | |||
There was a problem hiding this comment.
H5 组件的 view 标签需要统一调整为 div 标签。
某些其他 H5 组件内依然有使用 view 标签，主要是有一些历史原因暂时保留。
Closed
This reverts commit 81f0843.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
类似微信中的头像裁剪功能组件
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
这个 PR 是否已自测: